Conversation
Upper/Lower bounds updated via resource warnings in Jenkins CI dashboard. New reference files introduced as of icarus_ci build 15201, and these bounds were tuned via builds 15211, 15218, and 15222.
There was a problem hiding this comment.
🟡 Changes recommended
Calibrate or justify the unchanged reco0 thresholds in the active quick-test suite.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates quick CI resource bounds using recent Jenkins calibration data.
Changes:
- Recalibrates CPU and memory ranges for quick tests.
- Updates calibration metadata and removes a redundant commented suite entry.
- Requires updating or documenting the unchanged
reco0thresholds.
File summaries
| File | Summary |
|---|---|
test/ci/ci_tests.cfg |
Updates quick-test resource limits; reco0 remains on potentially stale thresholds. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cerati
left a comment
cerati
left a comment
There was a problem hiding this comment.
I do not see anything wrong, and the change in requirements seem reasonable. Vito might have more insights. Also, I am not sure what the Copilot comment means. But as far as I am concerned this is approved
vitodb
left a comment
vitodb
left a comment
There was a problem hiding this comment.
The resource ranges seem to be too wide to effectively catch changes in resource usage for future PRs.
Memory fluctuation in general are quite narrow, this allow for smaller memory ranges.
While CPU usage fluctuations are wider, but in many cases still smaller than the current ranges.
Upper/Lower bounds updated via resource warnings in Jenkins CI dashboard. New reference files introduced as of icarus_ci build 15201, and these bounds were tuned via builds 15211, 15218, and 15222.