Repository navigation
chore: release 1.19.0 - #144
Merged
Merged
Conversation
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the version to 1.19.0 and promotes the changelog. The release carries #142 (dense solves that no longer depend on
n_modes, weight restoring on deck-built floaters, WindIO discovery path scope, NumPy 1.26 support) and #143 (HydroDyn filled-member ballast).It is a minor bump rather than a patch because numerical outputs move. Every dense-path model shifts by up to the old solver error: up to about 5 % on the lowest NREL 5MW blade modes and about 0.3 % on the tower. Deck-built floaters gain their roll and pitch restoring, and OC4 gains its ballast.
Two commits:
chore: regenerate reference decks with the corrected dense solver. The six patched decks underreference_decks/pick up mode shapes from the corrected solve, so their polynomial coefficients move, typically a few percent on the blade blocks (NREL 5MWBldFl1Sh(3)2.612 → 2.590) and less on the tower. Every verdict is unchanged. This has its own Changed entry.chore: bump version to 1.19.0, promote CHANGELOG. Touches onlypyproject.toml, the__init__fallback,CITATION.cffandCHANGELOG.md.The bundled reference-turbine samples were rebuilt too. They came out identical to what #143 committed apart from line endings, so they are not part of this PR.
Pre-tag verification
Every step of
docs/release_checklist.rstup to the tag was run locally on this branch:--strict)TwSSM2ShWARNThe one manifest WARN is
bmodes, the archive-only clone with no git HEAD to pin. It is optional, maintainer-local and pre-dates this release.After merge, the Validation (external data) workflow runs on the merge commit before the
v1.19.0tag goes up, as the publish gate requires.