common/json: fix out-of-bounds slice in the comment scanner - #108
Merged
nekohasekai merged 1 commit intoSep 20, 2026
Merged
Conversation
AlexandrKhromov2005
force-pushed
the
fix/json-comment-scanner-oob
branch
from
August 8, 2026 04:11
efed245 to
c7ae07f
Compare
AlexandrKhromov2005
force-pushed
the
fix/json-comment-scanner-oob
branch
from
August 10, 2026 21:00
c7ae07f to
2bcbc39
Compare
nekohasekai
force-pushed
the
dev
branch
4 times, most recently
from
September 12, 2026 05:32
2148fb7 to
7776850
Compare
nekohasekai
force-pushed
the
dev
branch
5 times, most recently
from
September 20, 2026 03:18
2364c27 to
0432d07
Compare
nekohasekai
force-pushed
the
fix/json-comment-scanner-oob
branch
from
September 20, 2026 04:22
2bcbc39 to
38b039c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skipJSONStringcan advance past the end of input when a string ends with an incomplete backslash escape. If the input also contains a comment, comment path collection can panic while slicing an object key instead of returning a JSON syntax error.Clamp the returned index to
len(data)so malformed input reaches normal syntax validation.Validation:
go test ./common/json/... -count=1passed.