Repository navigation
fix(tui): exit when the input terminal hangs up - #558
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a terminal proxy closes its PTY without delivering SIGHUP, Crossterm 0.29 can spin inside
pollindefinitely. The TUI's input budget cannot interrupt that call, leaving cc-switch using a full CPU core.Add a Unix TUI guard that observes terminal hangup without reading input. A confirmed hangup terminates the process with status 129, since the input thread may never unwind. Normal connected-terminal exits retain the existing terminal restoration. The guard is scoped to the TUI; dependencies and input parsing stay unchanged.
Fixes #555.
Validation:
cargo fmt --checkpassed.reversed_empty_rangeserror in unchangedhome_chart.rs:806. Running the same check with only that lint allowed succeeds, with no warnings in the new files.