Skip to content

fix(webdav-sync): keep file symlink names in skills archives - #559

Merged
SaladDay merged 2 commits into
mainfrom
fix/webdav-skill-symlink-names
Nov 12, 2026
Merged

SaladDay merged 2 commits into
mainfrom
fix/webdav-skill-symlink-names

Conversation

@SaladDay

Copy link
Copy Markdown
Owner

Problem

A skill with file symlinks such as CLAUDE.md -> AGENTS.md wrote every alias under its target's name. The skills zip got duplicate entries, and WebDAV/S3 upload failed with Duplicate filename.

Fix

File entries use the link's own path and read content from the target. Directories keep canonical names, so traversal and cycle detection are unchanged. Ports upstream farion1231/cc-switch#9197.

Testing

  • zip_preserves_file_symlink_names_and_contents fails before the fix with Duplicate filename and passes after
  • zip_keeps_canonical_directory_names_and_skips_cycles and zip_skips_file_symlinks_outside_root pin the unchanged directory and outside-root behavior
  • Full cargo test -- --test-threads=1: no new failures; the 12 tests that fail here also fail on unmodified main
  • cargo fmt --check passes

A skill with file symlinks such as CLAUDE.md -> AGENTS.md named every
alias after its target, so the skills zip got duplicate entries and
WebDAV/S3 upload failed with "Duplicate filename".

File entries now use the link's own path and read content from the
target. Directories keep canonical names, so traversal and cycle
detection are unchanged. Ports farion1231/cc-switch#9197.
@SaladDay
SaladDay merged commit 65c2c83 into main Nov 12, 2026
6 checks passed
@SaladDay

Copy link
Copy Markdown
Owner Author

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant