Repository navigation
fix(webdav-sync): keep file symlink names in skills archives - #559
Merged
Merged
Conversation
A skill with file symlinks such as CLAUDE.md -> AGENTS.md named every alias after its target, so the skills zip got duplicate entries and WebDAV/S3 upload failed with "Duplicate filename". File entries now use the link's own path and read content from the target. Directories keep canonical names, so traversal and cycle detection are unchanged. Ports farion1231/cc-switch#9197.
Owner
Author
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A skill with file symlinks such as
CLAUDE.md -> AGENTS.mdwrote every alias under its target's name. The skills zip got duplicate entries, and WebDAV/S3 upload failed withDuplicate filename.Fix
File entries use the link's own path and read content from the target. Directories keep canonical names, so traversal and cycle detection are unchanged. Ports upstream farion1231/cc-switch#9197.
Testing
zip_preserves_file_symlink_names_and_contentsfails before the fix withDuplicate filenameand passes afterzip_keeps_canonical_directory_names_and_skips_cyclesandzip_skips_file_symlinks_outside_rootpin the unchanged directory and outside-root behaviorcargo test -- --test-threads=1: no new failures; the 12 tests that fail here also fail on unmodifiedmaincargo fmt --checkpasses