Skip to content

Better logic / handle scoping in case_sensitive? #2

Description

@ronen

schema_plus_columns' case_sensitive? postgresql implementation returns true if any index that the column is involved in is case sensitive. That isn't always what you want; see the discussion in the commit message of @dmeranda's commit 89f54f to SchemaPlus/schema_validations#39.

Perhaps case_sensitive? should take an optional argument specifying a scope. (If so, mysql should likewise accept a scope argument that it would ignore -- see #1) If a scope were provided, it could be used to obviate the extra logic in @dmeranda's commit 89f54f.

And should the default behavior (no scope specified) change to be something more conservative? That'd be a breaking change of course.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions