Conversation
schematic-bot
approved these changes
Sep 17, 2026
bpapillon
deleted the
bpapillon/sch-7476-sdk-lease-acquire-and-extend-retry-without-an-idempotency
branch
September 17, 2026 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lease wire client already let the generated credits client retry acquire and extend under the default policy, and extend carried no idempotency key, so a 502 arriving after the server committed the growth would grow the lease twice. The API now accepts an
idempotency_keyon extend (schematic-api #8556); acquire has always handed back the slot's existing active lease.Extend now mints one UUID per call and sends it as the key. The retry loop resends the same body, so every attempt of one extend collapses to a single grow while a later extend gets its own key. The check-and-reserve path still carries no key and keeps its no-retry setting.
Tests drive the generated client over a mock transport that replays 502 then 200: extend sends the same key on both attempts and the manager applies the response once, acquire installs the lease from the 200, and two extends carry different keys.