Conversation
bpapillon
force-pushed
the
bpapillon/sch-7488-sdk-check-that-joins-a-running-lease-extend-does-not-get-its
branch
from
September 17, 2026 00:52
407bc0c to
63fb786
Compare
schematic-bot
approved these changes
Sep 17, 2026
bpapillon
deleted the
bpapillon/sch-7488-sdk-check-that-joins-a-running-lease-extend-does-not-get-its
branch
September 17, 2026 00:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend is single-flight per slot, so a check that arrives while an extend is in flight joins it and gets whatever that extend asked for. A background extend for the default tranche running when a check needs more than the tranche left the check failing with insufficient lease balance while the server still had the credits.
Ports the shape from schematic-node #187. The flight records the additional amount its wire call asked for, sized one level above the wire call so the registered figure and the request body match. A joiner whose shortfall exceeds the flight's ask waits the flight out, re-reads the slot, and issues exactly one follow-up extend for the difference. A follow-up never chains, so a server that cannot cover the request does not spin, and the flight cleanup is identity-guarded so it cannot evict a follow-up registered under the same key. Watermark joiners and any check the tranche covers still share one wire call.
SPEC.md carries the same joiner rule as Node. Tests cover the follow-up sizing, the no-chain rule, shared wire calls for in-tranche joiners, the cleanup guard, and the end-to-end check that now reserves after one follow-up.