send an idempotency key on check-and-reserve and retry again - #125
Merged
bpapillon merged 1 commit intoSep 17, 2026
Conversation
schematic-bot
approved these changes
Sep 17, 2026
bpapillon
deleted the
bpapillon/sch-7499-check-and-reserve-has-no-idempotency-key-so-sdk-server-mode
branch
September 17, 2026 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server mode sent check-and-reserve with retries off, because a 502 after the API committed the hold would have made a retry a second hold. The API now dedupes on an idempotency key and answers a retry with the hold the first attempt took, so each check mints one key, sends it on the request, and drops the
max_retries: 0override, in both the sync and async clients. A transient 5xx now retries under the same key instead of surfacing as a failed check.