Skip to content

Fix broken mesh examples - #7168

Draft
ukmo-ccbunney wants to merge 3 commits into
SciTools:mainfrom
ukmo-ccbunney:bugfix/ww3_mesh_fix
Draft

ukmo-ccbunney wants to merge 3 commits into
SciTools:mainfrom
ukmo-ccbunney:bugfix/ww3_mesh_fix

Conversation

@ukmo-ccbunney

@ukmo-ccbunney ukmo-ccbunney commented Jun 24, 2026 •

Copy link
Copy Markdown
Contributor

Description

Closes: #6972

Fixes the use of iris.ugrid.MeshXY and iris.ugrid.Connectivity in the Mesh Conversion examples.

Also fixes missing AuxCoords in the WAVEWATCH III Mesh example.

Note: Banking this as a draft PR for now as we might want to use the planned "Add cube as component to cube" functionality proposed in #6829.

Checklist

Important

The Iris core developers are here to help! If anything below is unclear, just post a comment asking for help 😊


Tip

Things you can trigger on this PR:

  • Add this label to trigger benchmarks: benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts
  • Visit this URL - swapping 9999 for this PR's number - to re-trigger the CLA check:
    https://cla-assistant.io/check/SciTools/iris?pullRequest=9999

@codecov

codecov Bot commented Jun 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (5d7ca14) to head (e753a66).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7168   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files          91       91           
  Lines       24990    24990           
  Branches     4687     4687           
=======================================
  Hits        22529    22529           
  Misses       1683     1683           
  Partials      778      778           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ukmo-daisybrown

Copy link
Copy Markdown

Thank you so much for this @ukmo-ccbunney I was just looking at this exact example and trying to get it to work! You've saved us (me) a lot of effort, but we were curious how you came across this issue with the SMC example in the first place?

@ukmo-ccbunney

Copy link
Copy Markdown
Contributor Author

Thank you so much for this @ukmo-ccbunney I was just looking at this exact example and trying to get it to work! You've saved us (me) a lot of effort, but we were curious how you came across this issue with the SMC example in the first place?

I spotted it after someone came to the AVD Surgery with a related issue; I directed them to the example code and it failed. 😬

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

WAVEWATCH III SMC Mesh example code not working

2 participants