Repository navigation
feat(nav): Sign in link to app.scientfactory.com - #72
Merged
Merged
Conversation
The menu gains Sign in, which opens the hosted Scient. On phones the Home link hides (the brand already links home) so the menu fits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying scientfactory-website with
|
| Latest commit: |
b35fff7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d908473b.scientfactory-website.pages.dev |
| Branch Preview URL: | https://feature-sign-in-link-2026111.scientfactory-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Sign in to the end of the main menu (Home · About · Docs · Sign in). It opens https://app.scientfactory.com, where people use their Scient from any browser. That page now shares this site's header (symbol and ScientFactory name) and dark pill button, so the two read as one site.
On phones (≤ 480 px) the Home link hides, because the brand already links home; otherwise "Sign in" wrapped onto two lines and the menu ran into the name at 390 px. Menu links no longer wrap (
white-space: nowrap), and the nav keeps a 1 rem gap between brand and links.Documentation and source-version impact
Documentation impact: None — navigation only; no Docs content or source version changes.
Validation
bun run check(format, typecheck, events, tests, build, edge build) passed locally at b35fff7astro devat 1440 and 390 px only; needs the owner's look at the Cloudflare previewQuality Review
No material findings. One link added to the existing nav markup and style; the phone rule reuses the existing breakpoint pattern.
Integration Readiness Review
Owner authorized the merge 2026-11-11. Reviewed head b35fff7, author self-review. Awaiting the owner's preview review.
Deployment impact
Production nav gains an outbound link to app.scientfactory.com. Landing order: after ScientFactory/scient-desktop#852 (the redesigned hosted page) is deployed, so the link lands on the new page. No redirects or state changes.
🤖 Generated with Claude Code