Skip to content

feat(extensions): one row per account service, with one Connect - #920

Merged
yaacovcorcos merged 5 commits into
mainfrom
claude/account-services-20261114
Nov 14, 2026
Merged

yaacovcorcos merged 5 commits into
mainfrom
claude/account-services-20261114

Conversation

@yaacovcorcos

Copy link
Copy Markdown
Contributor

Stacked on #919. Retarget to main once #919 merges.

Gmail, Google Calendar and Google Drive exist only as account apps:

  • a ChatGPT app, which Codex and Scient Agent reach through their ChatGPT sign-in;
  • a claude.ai connector, which Claude reaches.

Before this PR, one service could show up as three separate rows. Now each service is one row.

What people see

  • Discover: in the Teamwork and Writing categories and in search, each service is a single row. Until Scient has read the agents' inventories, the row says it works "Through your ChatGPT or Claude account" and claims no connection state.
  • Detail page (/settings/extensions/item/account/<id>):
    • Connect in ChatGPT opens ChatGPT's page for the app in the system browser. One connection there serves both Codex and Scient Agent.
    • When only Claude still needs it, the button becomes Connect on claude.ai.
    • "Your agents" lists each agent with its state: connected, not connected, or sign-in needed.
    • "Works with" names the agents that have the service, plus the step each other agent still needs.
    • Returning from the browser re-reads the agents' inventories.
  • Installed: Connected services lists a service once any agent has it.
  • No duplicates: the From Scient Agent and From Claude sections no longer repeat these services, and category store lists hide Codex store entries for them.

How

  • apps/web/src/scient/extensions/accountServices.ts holds the services: each one's ChatGPT app id and claude.ai connector name. Adding a service is a data change.
  • Each agent's route comes from its own inventory:
  • New audience layer: ExtensionAudience gains account, which records the connected agents and the pending steps.

Known gap: Scient sees Codex's apps only through its installed plugins. A person who uses only Codex, with no Gmail plugin installed, sees Codex as "Not connected" even when their ChatGPT account has Gmail. Connect then opens ChatGPT's page, which shows it's already connected. The fix is to report Codex's account-level app/installed ids as inventory; that's a follow-up.

Checked

  • Root pnpm run typecheck, vp fmt, vp lint, knip, seam check and provenance.
  • New tests for routes, connect order, same-account Codex evidence, the audience label, and store-entry matching. All Extensions and Accounts tests pass (322).
  • Dev app built from this branch (macOS), signed in to the owner's Claude and Codex accounts:
    • The Teamwork category and the Gmail detail page render as intended. Screenshots are in reviews/account-apps-20261114/ in the ScientFactory workspace.
    • In Installed, From Claude no longer lists the claude.ai Gmail, Calendar or Drive rows.

Platforms: web-only logic. The provider pages open in the system browser on macOS, Windows and Linux alike. Tested on macOS only.

🤖 Generated with Claude Code

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XL labels Nov 14, 2026
@yaacovcorcos
yaacovcorcos force-pushed the claude/account-services-20261114 branch from a88adf1 to d1e54c6 Compare November 14, 2026 16:36
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.5 KiB 5.5 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 4.2 KiB 4.2 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.3 KiB 1.3 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 22.3 KiB 22.3 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.5 KiB 5.5 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 4.2 KiB 4.2 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.3 KiB 1.3 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 22.7 KiB 22.7 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Other scenarios

All 64 scenario measurements match main.

All 64 scenario measurements
Provider Scenario Metric Main baseline This PR Impact PR ceiling
Codex short turn resume WebSocket decoded 12.0 KiB 12.0 KiB 0 B (0.0%) 12.7 KiB ✅
Codex short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn running, cold open HTTP decoded 281.7 KiB 281.7 KiB 0 B (0.0%) 302.7 KiB ✅
Codex long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Codex long turn running, history page HTTP decoded 92.4 KiB 92.4 KiB 0 B (0.0%) 107.4 KiB ✅
Codex long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Codex long turn finished, cold open HTTP decoded 381.5 KiB 381.5 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, socket cold open WebSocket decoded 381.6 KiB 381.6 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, work page HTTP decoded 186.2 KiB 186.2 KiB 0 B (0.0%) 200.2 KiB ✅
Codex long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Codex idle thread resume WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell snapshot HTTP decoded 45.1 KiB 45.1 KiB 0 B (0.0%) 53.7 KiB ✅
Codex fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Codex fleet shell subscribe WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Codex fleet shell resume check rows 0 0 0 0 ✅
Codex stale shell reload HTTP decoded 45.1 KiB 45.1 KiB 0 B (0.0%) 53.7 KiB ✅
Codex stale shell reload rows 27 27 0 (0.0%) 27 ✅
Codex stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Codex stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex stale todo list cold open HTTP decoded 72.4 KiB 72.4 KiB 0 B (0.0%) 83.0 KiB ✅
Codex stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Codex stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅
Claude short turn resume WebSocket decoded 12.2 KiB 12.2 KiB 0 B (0.0%) 12.7 KiB ✅
Claude short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn running, cold open HTTP decoded 283.3 KiB 283.3 KiB 0 B (0.0%) 302.7 KiB ✅
Claude long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Claude long turn running, history page HTTP decoded 93.4 KiB 93.4 KiB 0 B (0.0%) 107.4 KiB ✅
Claude long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Claude long turn finished, cold open HTTP decoded 384.1 KiB 384.1 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, socket cold open WebSocket decoded 384.3 KiB 384.3 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, work page HTTP decoded 188.1 KiB 188.1 KiB 0 B (0.0%) 200.2 KiB ✅
Claude long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Claude idle thread resume WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell snapshot HTTP decoded 45.6 KiB 45.6 KiB 0 B (0.0%) 53.7 KiB ✅
Claude fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Claude fleet shell subscribe WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Claude fleet shell resume check rows 0 0 0 0 ✅
Claude stale shell reload HTTP decoded 45.6 KiB 45.6 KiB 0 B (0.0%) 53.7 KiB ✅
Claude stale shell reload rows 27 27 0 (0.0%) 27 ✅
Claude stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Claude stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude stale todo list cold open HTTP decoded 73.4 KiB 73.4 KiB 0 B (0.0%) 83.0 KiB ✅
Claude stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Claude stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅

Baseline: 54d8315 · PR result: 10a69c1 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Bounded compact HTTP snapshot with live cursor.

  • Codex decoded thread snapshot: 88.2 KiB
  • Claude decoded thread snapshot: 88.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

yaacovcorcos and others added 5 commits November 14, 2026 19:35
Gmail, Google Calendar and Google Drive exist only as account apps: a
ChatGPT app for Codex and Scient Agent, a claude.ai connector for Claude.
Each now shows once, in Discover's categories and search and, when any
agent has it, in Installed's Connected services. Works with lists the
agents that have it and the step each other one needs. Connect opens
ChatGPT's page for the app first, since one ChatGPT connection serves
Codex and Scient Agent, then claude.ai's connector settings; returning
re-reads the agents. A Scient Agent on the same ChatGPT email speaks for
Codex, whose apps only show through its plugins. The provider sections no
longer repeat these rows, and category store lists hide a Codex store
entry for one of them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… read

Discover reads no agent inventories, so its service rows now say they
work through a ChatGPT or Claude account instead of "Not connected yet",
and drop the duplicate Not connected status. Codex's plugin apps carry
their ChatGPT app id, which matches a service exactly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex reports a ChatGPT app as connected and, separately, whether it is
turned on there. A service whose app is turned off in Codex now shows
"Off in Codex", and the same ChatGPT account connected elsewhere no
longer marks it as working with Codex.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… its plugins

Codex reaches every app its ChatGPT account has connected, but Scient saw
Codex's apps only inside installed plugins, so a person using Codex alone
was told Gmail was not connected. Codex's inventory now also lists the
account's apps (app/installed, then app/read), as ChatGPT app rows beside
its MCP servers, leaving out ChatGPT's own connector_openai_* features.
Gmail, Calendar and Drive read Codex's state from them, an app turned off
in Codex shows as off, From Codex lists the other apps a plugin does not
already show, and the Accounts page lists them under Codex.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yaacovcorcos
yaacovcorcos force-pushed the claude/account-services-20261114 branch from 30b2291 to 10a69c1 Compare November 14, 2026 17:35
Base automatically changed from claude/chatgpt-apps-20261114 to main November 14, 2026 18:12
@yaacovcorcos
yaacovcorcos added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit f851d27 Nov 14, 2026
60 checks passed
@yaacovcorcos
yaacovcorcos deleted the claude/account-services-20261114 branch November 14, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant