Skip to content

Align with T3 through 2bee33eb19 - #929

Merged
yaacovcorcos merged 113 commits into
mainfrom
codex/t3-sync-2bee33eb19-20261114
Nov 14, 2026
Merged

yaacovcorcos merged 113 commits into
mainfrom
codex/t3-sync-2bee33eb19-20261114

Conversation

@yaacovcorcos

Copy link
Copy Markdown
Contributor

Aligns Scient with T3 through 2bee33eb19: one literal merge of T3's 104 commits after 997b304dd6, then the fixes the suites, Codex's review and the live review asked for. The record is docs/internals/t3-upstream-sync-20261114-2bee33eb19.md.

What users get

  • Node 26.13.1: the runtime moves to Node's November security release. Its newer SQLite would have stored some migrated JSON as text; T3's migration fix is taken, and none of Scient's own SQL has that shape.
  • Claude titles: renaming a thread renames the Claude session, and /rename in Claude retitles the thread.
  • Forks: switching a forked thread to another agent hands over the conversation it inherited.
  • Steadier agents: tools running at Stop show as stopped; Claude's root refusal is shown when it exits before the turn; turn recovery covers interrupted and cancelled runs; queued messages no longer wait behind later delegate completions; a steer that misses its turn moves into the run it starts.
  • Git: status refreshes read local status once unless refs moved and skip the untracked scan when there is none; idle worktrees follow a renamed or switched branch for cleanup; worktrees are removed through their owning repository.
  • Chat and files: pasted images keep their insertion point; typing in the file editor no longer jumps to the prompt; completed Markdown renders once; Arabic and Hebrew folds read right to left; Cite works on text an agent sent with send_to_user; browser tabs show their address at once.
  • Models: Claude Fable 5.2 needs Claude Code 2.1.321, in the live model list shipped builds read from main.
  • Phone app: a dozen fixes, among them text size, the caret before chips and Android shortcuts.

Scient composition

  • Kept Scient's: the lazy Files tree (T3's large-folder rebuild is ported in a stacked PR) and pdf.js find.
  • Claude adapter: T3's title, Stop and refusal changes are applied by hand onto Scient's adapter. A Stop now belongs to the workflow activation it was sent to, since Scient reopens settled workflows.
  • Forks: the Orchestrator reads only T3's run-fork ancestors; a Scient fork's frozen rows already arrive as its runless rows.
  • OpenCode: T3 keeps cached models through a cold server's empty probe; a logout still clears them.
  • Dev runner: T3's first-start build looks for Scient's scient-resource-monitor binary; T3's name would rebuild on every start.
  • No new migrations. T3's edit to migration 026 leaves databases that already applied it unchanged.
  • Owned main: feat(web): Goal and Plan chips in the composer #926 is merged in over the upstream merge.

Verification

  • Static checks: root typecheck (60 packages), lint, fmt, knip, brand, both generate --check steps, seam and provenance checks pass. The lockfile keeps 138 hasBin markers.
  • Full suites (Node 26.13.1, no live-profile variables): server 17,305, web unit 11,407, mobile 3,539, client-runtime 2,361, contracts, relay, desktop, scripts and the provider packages pass after the fits in the record.
    • Local-only failures: ClaudeSkills (case-insensitive disk), LatexRealEngine (fails on main), the port scanner's agent stop (ps -E), a setup-script syntax error that Apple's bash 3.2 exits with 1, a file-watch test where macOS reports a file's creation late (fails on the owned base too), T3's printenv copy test and two SSH race tests. CI runs them on Linux.
    • Web browser tests: the touched areas pass alone; CI's shards are the record.
  • Codex review (GPT-6.1 Sol, high): two findings, both fixed (Stop across workflow activations; frozen fork rows read in full before the bounded selection). Nothing found in the other ports.
  • Live review on a dev app (reviews/t3-sync-2bee-20261114/RECORD.md, workspace): bare @; a Codex turn; a fork switched to Claude recalling the Codex conversation; Claude's /rename; a Scient title change reaching the Claude session; the browser start page and navigation; no "T3" across 27 Settings pages.

Platforms

  • macOS arm64: all of the above, run locally.
  • Windows and Linux: not run locally; CI covers them.

🤖 Generated with Claude Code

saphid and others added 30 commits November 14, 2026 07:20
…es (#29867)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Alex Southwell <4596216+saphid@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…changes (#36786)

Co-authored-by: Alex Southwell <4596216+saphid@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
… 09:00 (#36789)

Co-authored-by: Alex Southwell <4596216+saphid@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…(#36758)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…#29802)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…9857)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… (#29785)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…s load or after a network blip (#28708)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…8945)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…h the server rejects (#29845)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… the message (#29834)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…t (#29850)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…elled queued messages (#29874)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…#33294)

Co-authored-by: Geezy <igor.licko@gloryck.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ry (#29809)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…eview (#29822)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…rst (#29871)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
… run in 60 minutes" (#29756)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ose (#36818)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…el (#29996)

Co-authored-by: Nathan Wong <20381195+thelogicmatrix@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…own merge request (#29791)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… to 3x later (#33550)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…composer (#33341)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge and others added 20 commits November 14, 2026 11:17
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…subsequences (#26376)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
…5122)

Co-authored-by: user <user@qubes-os.org>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ndoned turns (#34639)

Co-authored-by: Ali-Al1 <Ali-Al1@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…883)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Literal merge of the 104 official T3 commits after 997b304 through
2bee33e, composed with Scient.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add renameSession to Scient's Claude query mocks, provide the branch
follow-up services in Scient's cleanup tests, pass the stable PR panel
reader to Sections rows, drop the test of the deleted tree reconciler
and keep the listing error as the typed cause.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- A workflow Stop only marks failures of the activation it was sent to,
  as Scient reopens settled workflows.
- Provider switches read only run-fork ancestors; a Scient fork's frozen
  rows already arrive as its runless rows, without reading every body.
- The dev runner checks for Scient's resource monitor binary name.
- The dev container follows the Node 26.13.1 engine.
- Scient's tests keep its cookie skip counts and its wider file link
  pattern, which needs no ./ prefix for punctuated paths.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The send_to_user citation test looks for Scient's Ask in chat action,
and the preview mock's desktop view is idle on Scient's start page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- OpenCode keeps T3's cached models through a cold server's empty
  warning, but a logout, reported as no connected upstream providers,
  still clears them.
- Scient's server test app stubs T3's ref snapshot, its launch harness
  keeps the checkpoint mock over the replay harness's real store, and
  its review preview and status refresh tests expect T3's change types
  and single local read.
- T3's root refusal test accepts the refusal as the start's failure or
  the turn's, as Scient's start can claim the query first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XXL labels Nov 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR changes the test suite by +90 test cases (browser +10, unit +53, server +27).

New browser test files: apps/web/src/components/diffs/StyledDiffCodeView.browser.test.tsx, apps/web/src/components/settings/IntegrationsSettings.browser.test.tsx.
Each browser test file costs CI seconds of module loading before its first test runs; a unit test costs milliseconds.

Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing.

T3's custom-model draft closes only once its save resolves true.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.5 KiB 5.5 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 4.2 KiB 4.2 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.3 KiB 1.3 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 22.3 KiB 22.3 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.5 KiB 5.5 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 4.2 KiB 4.2 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.3 KiB 1.3 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 22.7 KiB 22.7 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Other scenarios

All 64 scenario measurements match main.

All 64 scenario measurements
Provider Scenario Metric Main baseline This PR Impact PR ceiling
Codex short turn resume WebSocket decoded 12.0 KiB 12.0 KiB 0 B (0.0%) 12.7 KiB ✅
Codex short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn running, cold open HTTP decoded 281.7 KiB 281.7 KiB 0 B (0.0%) 302.7 KiB ✅
Codex long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Codex long turn running, history page HTTP decoded 92.4 KiB 92.4 KiB 0 B (0.0%) 107.4 KiB ✅
Codex long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Codex long turn finished, cold open HTTP decoded 381.5 KiB 381.5 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, socket cold open WebSocket decoded 381.6 KiB 381.6 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Codex long turn finished, work page HTTP decoded 186.2 KiB 186.2 KiB 0 B (0.0%) 200.2 KiB ✅
Codex long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Codex idle thread resume WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell snapshot HTTP decoded 45.1 KiB 45.1 KiB 0 B (0.0%) 53.7 KiB ✅
Codex fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Codex fleet shell subscribe WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Codex fleet shell resume check rows 0 0 0 0 ✅
Codex stale shell reload HTTP decoded 45.1 KiB 45.1 KiB 0 B (0.0%) 53.7 KiB ✅
Codex stale shell reload rows 27 27 0 (0.0%) 27 ✅
Codex stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Codex stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex stale todo list cold open HTTP decoded 72.4 KiB 72.4 KiB 0 B (0.0%) 83.0 KiB ✅
Codex stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Codex stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅
Claude short turn resume WebSocket decoded 12.2 KiB 12.2 KiB 0 B (0.0%) 12.7 KiB ✅
Claude short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn running, cold open HTTP decoded 283.3 KiB 283.3 KiB 0 B (0.0%) 302.7 KiB ✅
Claude long turn running, cold open rows 75 75 0 (0.0%) 75 ✅
Claude long turn running, history page HTTP decoded 93.4 KiB 93.4 KiB 0 B (0.0%) 107.4 KiB ✅
Claude long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Claude long turn finished, cold open HTTP decoded 384.1 KiB 384.1 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, socket cold open WebSocket decoded 384.3 KiB 384.3 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn finished, socket cold open rows 151 151 0 (0.0%) 151 ✅
Claude long turn finished, work page HTTP decoded 188.1 KiB 188.1 KiB 0 B (0.0%) 200.2 KiB ✅
Claude long turn finished, work page rows 150 150 0 (0.0%) 150 ✅
Claude idle thread resume WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell snapshot HTTP decoded 45.6 KiB 45.6 KiB 0 B (0.0%) 53.7 KiB ✅
Claude fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Claude fleet shell subscribe WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Claude fleet shell resume check rows 0 0 0 0 ✅
Claude stale shell reload HTTP decoded 45.6 KiB 45.6 KiB 0 B (0.0%) 53.7 KiB ✅
Claude stale shell reload rows 27 27 0 (0.0%) 27 ✅
Claude stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Claude stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude stale todo list cold open HTTP decoded 73.4 KiB 73.4 KiB 0 B (0.0%) 83.0 KiB ✅
Claude stale todo list cold open rows 75 75 0 (0.0%) 75 ✅
Claude stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅

Baseline: ab54752 · PR result: a2a39da · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Bounded compact HTTP snapshot with live cursor.

  • Codex decoded thread snapshot: 88.2 KiB
  • Claude decoded thread snapshot: 88.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@yaacovcorcos
yaacovcorcos added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit 6ef4b17 Nov 14, 2026
63 checks passed
@yaacovcorcos
yaacovcorcos deleted the codex/t3-sync-2bee33eb19-20261114 branch November 14, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.