Repository navigation
Release: edge-apps-actions v26.10.2 (development → main) - #29
Open
salmanfarisvp wants to merge 8 commits into
Open
salmanfarisvp wants to merge 8 commits into
salmanfarisvp wants to merge 8 commits into
Conversation
* chore(deps): bump @screenly/edge-apps to 1.2.1 Removes the screen name from the app header (Screenly/edge-apps-library#56). * chore: regenerate screenshots for app-header fix Screenshot regeneration failed on the previous commit due to memory pressure on the dev machine. Re-ran cleanly and confirmed the header no longer shows the screen name.
- Set STAGE_EDGE_APP_ID and PRODUCTION_EDGE_APP_ID repo variables and pass them through to the initialize/update actions as edge_app_id - Drop id from screenly.yml and delete screenly_qc.yml since a single manifest is now used regardless of environment - Pin edge-apps-actions to a commit for now, since v26.9.0 can't be tagged there until a repo ruleset is adjusted
Deploy stage on pushes to the default branch and production on vYY.M.PATCH tags, refusing tags not on the default branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Checks, Initialize and Update now call the reusable workflows; deploys queue instead of running side by side. Dependabot checks GitHub Actions weekly and targets development, so pin bumps go through the usual flow.
Use edge-apps-actions v26.10.2 and add release badge to README
There was a problem hiding this comment.
🟡 Changes recommended
A critical workflow glob can trigger production deployments for malformed or prerelease tags, so the CalVer-only release process is not enforced; the documentation inconsistencies are secondary.
3 open issues
What changed in this PR
Promotes development to main, adopting edge-apps-actions v26.10.2 reusable workflows and updating release documentation and dependencies.
Changes:
- Replaces local CI, initialization, and deployment logic with reusable workflows.
- Configures stage deployments from
mainand production deployments from versioned tags. - Removes environment-specific manifest configuration.
- Updates
@screenly/edge-appsto1.2.1and refreshesbun.lock. - Adds release documentation, a badge, and preview imagery.
This pull request requires changes.
| File | Summary |
|---|---|
screenly.yml |
Removes the environment-specific manifest ID. |
screenly_qc.yml |
Removes the obsolete QC manifest. |
README.md |
Adds release documentation, a badge, and preview imagery. Nits: align the hard-coded release example with v26.10.2 and regenerate screenshots after the dependency upgrade. |
package.json |
Bumps @screenly/edge-apps to 1.2.1. Nit: regenerate affected screenshot assets to reflect the updated UI. |
bun.lock |
Records the updated dependency resolution and transitive packages. |
.github/workflows/update-edge-app.yml |
Uses the v26.10.2 reusable deployment workflow for stage and production. Critical: the tag glob accepts non-CalVer and prerelease tags, potentially triggering production deployments. |
.github/workflows/initialize-edge-app.yml |
Uses the v26.10.2 reusable initialization workflow. |
.github/workflows/checks.yml |
Uses the v26.10.2 reusable checks workflow. |
.github/dependabot.yml |
Enables weekly GitHub Actions dependency updates targeting development. |
Review effort: Lite
| - main | ||
| - master | ||
| tags: | ||
| - 'v[0-9]*' |
|
|
||
| # Airtable App | ||
|
|
||
|  |
Comment on lines
+92
to
+94
| git tag v26.10.0 | ||
| git push origin v26.10.0 | ||
| ``` |
514sid
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
developmenttomain. This switches the app's CI to the edge-apps-actions v26.10.2 reusable workflows (Checks, Initialize Edge App, Update Edge App), and brings the README release docs.Changes since
mainAfter merging
main→ deploy to stage, which waits for approval in thestageenvironment.main(vYY.MM.N) and push the tag → deploy to production, which also waits for approval. Tags that aren't onmainare refused.