Skip to content

fix(settings): group Zack settings under Holographic memory and LCM - #100

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/zack-settings-groups
Nov 10, 2026
Merged

ScriptedAlchemy merged 1 commit into
mainfrom
fix/zack-settings-groups

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Why

The Memory and history group in Settings → Labs → Zack mixed two systems ported from TraceDecay. A setting did not say which system it belongs to.

What changed

  • Save facts from finished runs sits under Holographic memory.
  • Summarize older messages and External history sit under LCM (lossless context management).
  • Mobile uses the same names for its sections, and settings search finds these settings by "lcm" and "holographic".

Scope

  • Headings and search terms only. No setting changes its behavior, key, or default.
  • The other Zack groups keep their names.

Blast Radius

Labels in one settings page on web and one on mobile.

Verification

  • vp run check:changed passes.
  • Opened Settings → Labs in the dev build from this branch. Both new headings render with their settings. The capture is kept locally and is not attached here.
  • Mobile was not opened on a device.

Model and harness: Claude Fable 5.2 in T3 Code (Claude Code).

🤖 Generated with Claude Code

@changeset-bot

changeset-bot Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 83e5171

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

The Memory and history group mixed two systems, so a setting did not say
which one it belongs to. Save facts from finished runs now sits under
Holographic memory. Summarize older messages and External history sit under
LCM. Mobile uses the same names, and settings search finds them by "lcm"
and "holographic".

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@ScriptedAlchemy
ScriptedAlchemy force-pushed the fix/zack-settings-groups branch from 5e6e080 to 83e5171 Compare November 9, 2026 23:50
@ScriptedAlchemy

Copy link
Copy Markdown
Owner Author

PASS+NOTES — head 83e5171494c5e7fc24bda047e39eee2d5ea5b852

Verified independently on a clean checkout of fix/zack-settings-groups.

Commands run and results:

  • git diff origin/main...HEAD — 4 files, 18 insertions, 7 deletions; only headings and search terms.
  • vp i — installed 1672 packages (worktree had no node_modules).
  • vp run check:changed — all pass: format 1.3s, lint 1.4s, knip 2/2 24.3s/31.0s, typecheck (3 packages) 39.3s, test (3 files) 26.1s, react compiler (4 files) 12.4s.
  • Temporary tests (written, run, then deleted) exercising the real search functions:
    • searchSettings("lcm") returns conversation-summaries and external-history; searchSettings("holographic") returns assisted-learning on web.
    • filterSettingsSections(sections, "lcm" | "holographic") returns the Labs page on mobile. 2/2 passed.
  • grep for Memory and history across the repo — no matches; no test or code expects the old heading.

Claim check:

  1. Web: ZackSettings.tsx puts AssistedLearningRow ("Save facts from finished runs") under "Holographic memory" and ConversationSummariesRow ("Summarize older messages") + ExternalHistoryRow under "LCM (lossless context management)". Confirmed.
  2. Mobile: section titles are "Holographic memory", "LCM: conversation summaries", "LCM: external history". Confirmed.
  3. Web search finds the individual settings by "lcm" and "holographic". Confirmed. Mobile search terms were added to the SettingsLabs page group, so the mobile index search surfaces the Labs page, not an individual setting row — consistent with how the pre-existing "project memory"/"conversation summaries" terms work there.
  4. No file under packages/contracts; no updateSettings, write(, setting key, default, or behavior change in the diff. Confirmed.

Note only: mobile search is page-level, so a "lcm" query shows "Labs" rather than the renamed sections. No action required for this PR's stated scope; nothing else expects the old titles.

@ScriptedAlchemy
ScriptedAlchemy merged commit 22bcdba into main Nov 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant