Repository navigation
test(server): CodexDriver auth.json watch test no longer needs codex on PATH - #114
Merged
Merged
Conversation
…on PATH On a host without codex on PATH the driver asks the mocked CodexInstallation to acquire a binary. The mock has no acquire, so the probe dies before it spawns and the test waits for a probe that never comes. CI runners have no codex, so the test timed out on every run, main included. Give the test an explicit binary path so the driver skips the PATH lookup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ScriptedAlchemy
enabled auto-merge (squash)
November 12, 2026 23:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The required Fork Check is red on main and on every PR. One test, "probes again when auth.json in the Codex home changes", times out after 120 s on CI. It passes only on machines that have
codexon PATH, and CI runners do not.What changed
Scope
CodexInstallation.acquire. The shared test mock has noacquire, so the probe failed before it spawned and the test waited forever. Production uses the real installation service and is not affected.Blast Radius
Test-only. While main stays red, auto-merge is blocked on every fork PR, including #113.
Verification
codexremoved from PATH, the test failed before the fix (timed out in 120000ms). After the fix, all 21 tests inCodexDriver.test.tspass, with and withoutcodexon PATH.vp run check:changedpasses.Done by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code