Repository navigation
fix(ci): shard fork web tests so Chromium stops closing mid-run - #119
Merged
Merged
Conversation
Fork CI ran all 588 web browser test files in one headless Chromium on a standard runner. It ran out of memory and closed partway through, failing main and every PR on a different file each time. Upstream already shards this suite; fork CI now does too, across four runners. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork CI's "Client and package tests" ran all 588 web browser test files in one headless Chromium on a standard GitHub runner. Partway through, the browser closes (
VITEST_BROWSER_CONNECTION_CLOSED), each time on a different file:runtime.browser.test.tsandDiffFileLoadingBoundary.browser.test.tsxon #115, andUsageLimitsPooled.browser.test.tsxonmainafter #118. Every test that ran passed, but the job fails, and so does Fork Check.Upstream's
ci.ymland the release workflow already shard this suite. Fork CI now runs the web tests in their ownWeb testsjob, sharded 1–4, using the same--shardcommand. "Client and package tests" keeps the release checks and package tests. Fork Check requires the new job and maps it to thetest_webgate.Checks: actionlint passes. Locally,
vp run --filter @t3tools/web test --shard 4/4ran 147 of the 588 files, and all passed.🤖 Generated with Claude Code