Repository navigation
fix: keep upstream lint rules instead of fork suppressions - #120
Merged
Merged
Conversation
- providerAccountSync uses runtime's withEnvironmentRpcPermissions, so it no longer needs a no-rpc-permission-bypass exemption. - PeerMcpClient binds the caller's result schema before decoding, as upstream does. - The server build config reads the host through HostProcess. - The mobile thread screen builds the usage-limits report when it opens the panel, from the same provider instance it later renders with, so the composer no longer reads the clock and needs no react/purity suppression. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork turned off several upstream lint rules, through a config exemption or inline disables, instead of fixing the code. This PR fixes the code and removes those suppressions.
providerAccountSync.tsused to install its ownRpcPermissionGuardand needed a config exemption. It now useswithEnvironmentRpcPermissionsfromruntime.ts, so the exemption is gone.PeerMcpClientnow binds the caller-supplied result schema to a local before decoding, as upstream's version does. The two disables are gone.vite.config.tsnow reads the host throughHostProcess.PlatformandHostProcess.Architecture. Both default to the same running Node process, so the result is unchanged. The two disables are gone.Two suppressions stay on purpose:
native/project-memoryoverride. Those scripts run in the Rust CI job without workspace dependencies, the same reason upstream exemptsscripts/npm-launcher/**.no-unreasoned-state-syncdisables. They are the rule's own escape hatch.vp run check:changedpasses: format, lint, knip, typecheck of 42 packages, tests and the React compiler check.🤖 Generated with Claude Code