Repository navigation
fix(pstack): packaged desktop builds load pstack, and T3 hides native pstack plugins - #46
Merged
Merged
Conversation
… pstack plugins Desktop builds prune the statechart skill's test corpus, but the server still copied every manifest file, so the pack never materialized and no provider saw pstack. Delivery now skips the pruned directory. While pstack is on, T3 also switches off native `pstack@<marketplace>` plugins in the Codex and Claude sessions it launches, so agents see one copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Packaged desktop builds delete the statechart test corpus from the bundled pstack resources, but the server still copied every file in UPSTREAM.json, so materializing the pack failed with ENOENT and no /pstack:* skills loaded. The pruned directory is now one exported constant in @t3tools/pstack. pstackPackEntries excludes it from the runtime pack and the desktop build prunes exactly that directory, so a packaged source root is complete by construction. checkPack still verifies the full upstream source. Claude Opus 5.5 via T3 Code Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The unit test hardcoded the pruned directory, so a typo in PSTACK_PACKAGED_PRUNED_DIR would still pass it. It now derives the fixture paths from the constant, and a new case checks the shipped UPSTREAM.json actually carries files under that prefix so an upstream re-sync that renames the corpus cannot turn the filter into a no-op. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Parse Codex plugin configuration as TOML and include Claude launch settings when suppressing duplicate native pstack plugins. Cover quoted/dotted/inline TOML and inline/file --settings, preserving unrelated plugins and pstack-disabled sessions. Reviewed and repaired with GPT-6 Astra Pro through ChatGPT coding tools.
Keep the shared packaged-file pruning implementation from PR #51 alongside native plugin suppression. Preserve Claude's version-constrained plugin settings while suppressing native pstack whenever T3's pack is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With pstack turned on, the packaged desktop app never showed
pstack:skills in any provider, OpenCode included. Desktop builds pruneskills/statechart/scripts/testfrom the bundled pack (prunePackagedPstackTestFixtures), but the server still copied every file inUPSTREAM.json. Materializing the pack failed withENOENT … ConfigOracle.java, and the catalog came back empty.Separately, Codex and Claude sessions that had their own pstack plugin installed (for example
pstack@pstack-codex) registered a second, single-provider copy beside T3's pack.Fix
pstackPackEntriesskips the same directory the desktop build prunes. Against the installed Nightly bundle, all 204 runtime entries now resolve; before the fix, 376 were missing.pstackEnabledis on, T3 switches off nativepstack@*plugins in the sessions it launches. The user's own config files are not changed, so sessions outside T3 keep their plugins.-c plugins.<key>.enabled=falsefor each pstack plugin declared in the Codex home'sconfig.toml. The quoted formplugins."pstack@x".enabledis silently ignored because Codex splits-ckeys on dots and keeps the quotes. Verified with codex-cli 0.166.0skills/list: 141 → 87 skills, all 54pstack:skills removed.enabledPlugins: { "pstack@x": false }in the SDK flag settings, which take precedence over the user and project settings files. Not tested against a live Claude session, because no Claude pstack plugin was installed on the test machine.--settingsplugin values in the suppression decision, including version-constraint arrays and objects supported by the installed SDK. Preserve file/launch precedence, unrelated plugins, and native pstack when T3's pstack setting is off.Tests
packages/pstack/src/check.test.ts: delivery omits the pruned fixture directory.apps/server/src/pstack/nativePlugins.test.ts: Codex config parsing and the Claude override map.CodexAdapterV2"post-settle continuation" tests fail on unmodifiedmainas well. They are unrelated to this change.🤖 Generated with Claude Code
Follow-up repairs and validation
Latest repair: 362e874.
This merges #51 into this branch, resolves their overlapping pack filter, and retains #51's shared prune constant and packaging regressions alongside the native-plugin fixes. Both branch histories are preserved, so the packaging repair no longer conflicts with this PR.
The additional Claude defect was reproduced before repair: array/object plugin values in launch settings stayed enabled, and file-derived extended values were discarded before suppression. T3 now preserves those raw settings and disables effective pstack entries unless explicitly false. Existing native skill-discovery selection behavior is unchanged.
check:changed --concurrency 1 --timeout 300was attempted. Its native addon prerequisite timed out after 300 seconds, and its cached typecheck supervisor was deniedseccomp_unotify. After the useful fast checks completed, the remaining wrapper waiting on the native prerequisite was interrupted. The aggregate did not complete or pass. The focused tests and direct typechecks above passed independently; hosted CI remains a separate gate.Follow-up review and repairs: GPT-6 Astra Pro through ChatGPT coding tools.