Repository navigation
fix(ssh): reuse the desktop-installed CLI during remote setup - #47
Merged
Merged
Conversation
|
A wedged candidate stalled remote setup until the outer SSH timeout: a hung --version or __ssh-helper probe blocked forever, and an executable non-regular file (e.g. a FIFO) at a candidate path made the shell's read-as-script fallback block on open. Probe each candidate through a watchdog that falls through to the archive download, require a regular file, and route probe output through a temp file so orphaned children cannot hold the capture open. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH connections to a Mac with T3's desktop-installed CLI could fail when GitHub was unavailable. The remote runner checked PATH and
~/.local/bin/t3, but missed the desktop command at~/.t3/bin/t3, so it unnecessarily tried downloading a release archive.Check the desktop command location as well, retaining the exact-release and SSH-helper checks before reusing it. Extend the existing runner test to cover both installation locations.
Validation:
vp run check:changed --concurrency 2passed: format, lint, knip, five affected package typechecks, and 21 tests across two files.Hung probes: a candidate whose
--versionor__ssh-helper --helpnever returns (a wedged wrapper, or an executable FIFO at~/.t3/bin/t3) used to stall setup until the 900s SSH timeout. Candidates must now be regular files, and each probe runs under a 15s watchdog that falls through to the archive download. Cross-review proof (sh and dash, 45 resolution cases plus hang/FIFO/orphaned-pipe attacks) passed;vp test run packages/ssh/src/tunnel.test.tspasses 22/22 andvp run check:changedpasses.Model: GPT-6.1-Sol (high). Harness: Codex in T3 Code.