Repository navigation
fix(ci): checksum desktop installers in fork releases - #54
Merged
Merged
Conversation
SHA256SUMS in fork releases listed only the CLI archives, so anyone installing the desktop app from a release asset (AppImage, deb, dmg, zip, exe) had nothing published to verify it against. Build the list the same way release.yml does, with nullglob, and include the desktop installers. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork releases published a
SHA256SUMSthat covered only the CLI archives, so the desktop installers (AppImage, deb, dmg, zip, exe) had no published checksum. Updating omarchy today stalled on exactly that.The checksum step now builds its file list the way
release.ymldoes (nullglob, fail if empty) and includes the desktop installers alongside the CLI archives. The install scripts grepSHA256SUMSby archive name, so extra lines don't affect them.Verified with
actionlint.🤖 Generated with Claude Code
Model: Claude Fable 5.1 via Claude Code in T3 Code.