Repository navigation
fix(lint): main CI no longer fails on unreasoned effects - #65
Merged
Merged
Conversation
|
Eight effects had no stated reason, so the full-repository lint on main failed and took Fork Check with it. Each now names what it syncs with. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ScriptedAlchemy
force-pushed
the
fix/main-state-sync-lint
branch
from
November 5, 2026 05:02
49d7964 to
ad7575e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork CIhas failed onmainsince at least69b9b7bd.Validate full repositorystops on 8t3code/no-unreasoned-state-synclint errors, which also failsFork Check. PR runs only validate changed files, so they don't catch this.Each effect now has a suppression naming what it syncs with. There is no runtime change: seven are
ResizeObserversubscriptions, a non-passive wheel listener, imperative scroll, and clearing a keep-alive atom on unmount.The eighth is worth a look: the mobile
ProjectKnowledgeFactEditoreffect reportsdirtyto its parent, which the rule usually says to do in handlers instead. I kept it because it holds the parent's leave guard, which must start true for pre-filled drafts and be released on every unmount, so handlers alone can't replace it.Verification: I ran every command in that CI step locally:
vp check(0 errors, 4 existing warnings),knip:check, bothgenerate --checkcommands, and the recursive typecheck. All pass. This PR's own CI runs only the changed-file check, so the first full run of that step in CI will be the push tomainafter merging.Opus 5.5 via Claude Code in T3 Code.
🤖 Generated with Claude Code