Repository navigation
fix(mcp): expose account pool members for delegation checks - #70
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A delegation targeting
pool_claudeAgentreports the selected concrete account, such asclaudeAgent. Capabilities advertised the pool but omitted its member IDs, so agents could not verify that relationship and reported an unconfirmed provider mismatch even when model and effort matched.Change
Expose
poolMemberInstanceIdsfor account pools inorchestrator_capabilitiesand clarify the target/result schemas: compare the returned account with the advertised members, then check model and options separately. Extend the existing pool delegation test and add eval cases for an expected member and an unrelated account.Scope and approval
This is a focused fix for missing metadata in the existing delegation capability. It qualifies for the small obvious-bug exception: routing and execution behavior are unchanged; the response now exposes the relationship needed to interpret the result.
Prior implementation verification
poolMemberInstanceIdswas absent, then passed afterward. Non-pool providers omit the field.vp run check:changed HEAD: passed formatting, lint, knip, GraphQL validation, native-addon build, affected-package typechecks (36 packages), and adjacent tests (90 tests in four files).vibeproxyconfiguration; no model-behavior pass is claimed.Observed in the focused service test:
The original reported task was not independently traced; this change addresses the confirmed metadata gap.
Model: GPT-6.1 Sol (xhigh). Harness: Codex in T3 Code.
Current audit verification
Updated this branch with current
mainand the shared Android test-environment fixture fix. The published tree is the same tree verified locally.seccomp_unotifyprocess-tracing restriction. All 41 affected-package typecheck tasks passed when rerun serially withvp run --no-cache --parallel --concurrency-limit 1and the same package filters.Audit and fixes: GPT-6 Astra Pro in ChatGPT.