Repository navigation
feat(memory): save project facts without an approval queue - #72
Merged
ScriptedAlchemy merged 3 commits intoNov 6, 2026
Merged
Conversation
Migrate existing facts to a saved-or-forgotten lifecycle and update clients and agents together. Keep provenance, explicit supersession, feedback and TraceDecay-derived ranking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ScriptedAlchemy
added a commit
that referenced
this pull request
Nov 6, 2026
Removes Loom from web, desktop, mobile, server, contracts, and docs. Migration 91 drops the six indexes that only Loom read, and the shell's pending-secret lookup now names its status index so that drop does not change its plan. Also lands #72, which saves project facts without an approval queue. Migration 92 rewrites stored facts to the saved and forgotten states. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Project memories should save automatically without asking the user to review or approve suggestions. Replace the approval lifecycle with saved memories while keeping provenance and the existing TraceDecay-derived holographic ranking.
What changed
saved | forgotten, migrate existing facts in migration 92, and remove confirmation APIs and controls.Scope
Tradeoffs
Lexical similarity is not proof that two memories mean the same thing, so it cannot discard a distinct fact. The direct API migration deliberately drops compatibility with older clients.
Blast Radius
Each updated Electron installation migrates its own local database on startup. Update all linked installations and clients together; mixed versions may fail memory operations. Automatic learning adds a text-generation call per eligible run unless disabled, and previously omitted default-false settings become enabled.
Prior implementation verification
vp run check:changedpassed on the rebased commit, including 420 tests, affected-package typechecks, lint, formatting, dependency checks, and React compiler checks.Implemented with GPT-6.1 Sol in the Codex harness and Claude Opus 5.5 in the Claude Code harness.
Dependency and merge order
This PR depends on #71 (
t3/remove-loom-features) and is based on that branch so its review diff shows the memory changes. Merge #71 first, then retarget this PR tomainand merge it. Migration 91 removes the Loom indexes; migration 92 updates saved project memories. Both migrations are included in this branch to preserve a contiguous upgrade sequence.Follow-up audit
Automatic duplicate detection now compares normalized content against all current saved facts in bounded pages. It no longer depends on the three displayed similarity hints or the forty lexical neighbors, and it covers content without lexical tokens, including CJK text. The regression checks more than one page of competing facts, normalized whitespace/case, and a CJK duplicate.
The upgrade also recognizes this PR's earlier saved-memory schema recorded at migration 91. After checking that exact known history and schema, it applies the Loom index cleanup and moves the existing saved-memory receipt to 92 in one transaction. The regression verifies retained facts, history, command receipts, search results, and receipt timestamps, along with rollback on a failed receipt update and an unchanged second startup.
Current audit verification
vp run --no-cache --parallel --concurrency-limit 1. The cached task wrapper is blocked locally by aseccomp_unotifyprocess-tracing restriction. Final type-only row and tuple annotations received fresh file formatting/lint and typechecks, including the server on the final source tree.FileCodeRelationships.browser.test.tsxandProjectMemoryPanel.browser.test.tsx. Their browser behavior is not claimed as locally verified.Audit and fixes: GPT-6 Astra Pro in ChatGPT.