Skip to content

fix(mobile): prevent linked subagent messages from crashing conversations - #75

Merged
ScriptedAlchemy merged 2 commits into
mainfrom
codex/fix-mobile-conversation-update-loop
Nov 7, 2026
Merged

ScriptedAlchemy merged 2 commits into
mainfrom
codex/fix-mobile-conversation-update-loop

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

An assistant message that cites an idle subagent can crash the conversation with “Maximum update depth exceeded.” Loading its title changed the missing-title list, which released the family subscription and removed the title again. The repeated label changes reached the native markdown renderer's layout-effect callback.

Keep family subscriptions mounted for the identities cited by the message. Release them when the links change or the message unmounts. The regression checks the resolved title and release after removing the link. Family reads use the existing shared cache and reference counting.

Validation:

  • Reproduced on iPhone 17 / iOS 27.2 with the original code. The error points to EnrichedMarkdownText.tsx:185 (setParsedLinkUrls), matching the supplied release stack. The same conversation renders the resolved “Child result” link after the fix.
  • Regression fails before the fix with Thread title subscription loop and passes afterward.
  • vp run check:changed HEAD passed format, lint, knip, typecheck, 14 tests, and affected React Compiler checks. Four thread-family tests also passed.
  • Independent review found no blocking issues.

Model and harness: GPT-6-Astra with GPT-6.1-Terra assistance, Codex in T3 Code.

@changeset-bot

changeset-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2f71343

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy enabled auto-merge (squash) November 7, 2026 06:06
@ScriptedAlchemy
ScriptedAlchemy merged commit 189cfd8 into main Nov 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant