Repository navigation
fix(web): keep cited child threads available on desktop and web - #86
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A desktop chat could say “Thread no longer available” for an idle subagent that still existed. If the stored thread ID contained literal percent escapes, the renderer requested only the decoded ID. Even a successful lookup could lose its title when the renderer released the read that supplied it.
Keep the cited thread and its decoded fallback loaded while the citation is displayed. Prefer the ID as written and release both reads when the citation changes or unmounts. Desktop and web share this renderer. iOS and Android already retain the same candidates; the mobile regression now checks the opaque ID through title resolution and tap-target lookup.
The Chromium regression failed on the base revision and passed with the fix, including the destination and cleanup assertions. All 22 focused tests passed, as did
vp run check:changed origin/main. No live Electron or Android device session was available; the screenshots are from the Chromium component test.Model and harness: GPT-6, Codex.