Repository navigation
fix(ssh): detect installed services without a user manager - #88
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An SSH login that cannot reach the systemd user manager can still have an installed T3 Code service. The launcher treated a failed
systemctl --user catas no installed service and attempted to start a standalone server with different network settings.Check the installed user unit before querying systemd. Check the standard unit under
~/.configand any absoluteXDG_CONFIG_HOME. The SSH login can use a different config home from the session that installed the service. Keep the systemd query for units found through other manager paths. Existing launchd handling and standalone bootstrap remain covered by the same shell test table.Validation:
Failed to find an available portafter reaching standalone port selection, instead of refusing replacement witht3 service restart.npm_config_offline=true vp run check:changed origin/mainpassed.Shell regression evidence:
These tests execute the generated POSIX shell with temporary files and stubbed OS/service commands. They do not claim a live Linux SSH or systemd integration run.
Model: Codex (exact model identifier not exposed). Harness: Codex desktop.