Repository navigation
fix(server): share skills with configured account homes - #90
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skills library added in #34 scans the host's default harness homes but misses the profile a configured account actually uses. A Claude account with its own
CLAUDE_CONFIG_DIRand profile sharing enabled therefore keeps a separate skill catalog even after Refresh; explicit Claude/Codex homes have the same gap.Drivers now expose their already-resolved shared skills directory to the library. Refresh includes enabled account profiles, retains Claude private-profile opt-outs, deduplicates physical directory aliases, and reacts when a configured profile path changes. Codex covers existing, CLI, and managed accounts. A single scan distinguishes active profiles from previously linked profiles, so changed or removed accounts restore their old links without making retired copies part of the active catalog. Ownership is recorded before linking in this environment's userdata, survives restart and interrupted detach, and is retained while a staged-copy conflict remains. Detach restores Claude copies and removes Codex links according to the existing ownership policy.
Validation:
applynever created~/.agents/skills/custom/SKILL.md.vp run check:changed origin/mainpasses, including 37 changed-area tests and typechecks of 26 affected/dependent packages.Model and harness: GPT-6 / Codex.