Skip to content

fix(server): share skills with configured account homes - #90

Merged
ScriptedAlchemy merged 2 commits into
mainfrom
codex/audit-pstack-assets
Nov 9, 2026
Merged

ScriptedAlchemy merged 2 commits into
mainfrom
codex/audit-pstack-assets

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

The skills library added in #34 scans the host's default harness homes but misses the profile a configured account actually uses. A Claude account with its own CLAUDE_CONFIG_DIR and profile sharing enabled therefore keeps a separate skill catalog even after Refresh; explicit Claude/Codex homes have the same gap.

Drivers now expose their already-resolved shared skills directory to the library. Refresh includes enabled account profiles, retains Claude private-profile opt-outs, deduplicates physical directory aliases, and reacts when a configured profile path changes. Codex covers existing, CLI, and managed accounts. A single scan distinguishes active profiles from previously linked profiles, so changed or removed accounts restore their old links without making retired copies part of the active catalog. Ownership is recorded before linking in this environment's userdata, survives restart and interrupted detach, and is retained while a staged-copy conflict remains. Detach restores Claude copies and removes Codex links according to the existing ownership policy.

Validation:

  • The custom-profile regression failed before the fix: apply never created ~/.agents/skills/custom/SKILL.md.
  • Runtime fixture transcript: custom profile skill → library; library skill → configured profile; a second apply preserves both; detach restores real Claude copies. Disabled profiles stay untouched and aliased roots are processed once. Reassignment restores the former home immediately; restart completes detach even after an account disappears. Missing/reassigned roots remain untouched, and a second environment with the same OS home cannot consume the first environment's ownership journal.
  • Offline vp run check:changed origin/main passes, including 37 changed-area tests and typechecks of 26 affected/dependent packages.
  • Additional pstack, model-resolution, native-plugin, pool, Claude discovery, overlay, and MCP suites: 262 tests passed.
  • Server-only behavior, shared by web, desktop, mobile, and MCP. No client UI changes or paid provider turns.

Model and harness: GPT-6 / Codex.

@changeset-bot

changeset-bot Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 54151be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy merged commit 3e54126 into main Nov 9, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant