Repository navigation
test(cli): remove the artificial launcher probe deadline - #91
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unusable-release fixture introduced in #62 replaces the launcher’s 30-second validation bound with 500ms. On a loaded host, valid shell fixture startup can exhaust that bound before writing stderr or its ready marker, so the test fails before exercising the intended behavior.
Remove the artificial timeout hook and run the four failure fixtures as separate live tests under the existing project ceiling. The hanging probe uses the production bound and still checks that it started, timed out without invoking its TERM trap, and left no published install. Missing-loader, stderr failure and actual SIGTERM coverage remain; the signal and timeout diagnostics are now explicit assertions.
Validation: the original test failed repeatedly with ETIMEDOUT before its stderr/ready assertions. The repaired file passes all 5 tests, and
npm_config_offline=true vp run check:changed origin/mainpasses format, lint, both Knip passes, scripts typecheck and all changed tests. All five tests passed on macOS. Also exercised the actual Node launcher in a Debian ARM64 container for successful installation, stderr failure, SIGTERM, and ETIMEDOUT with no partial install. The POSIX fixtures skip Windows. The probe blocks on a FIFO and uses negligible CPU during the 30-second production timeout.Model and harness: GPT-6, Codex.