Repository navigation
fix(release): preserve mirror queries when downloading assets - #92
Merged
Merged
Conversation
|
ScriptedAlchemy
enabled auto-merge (squash)
November 9, 2026 02:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release mirror configured with a query string could return 404s during an update or fresh installation. Parts of the fork appended the version and filename after the query string. Alpine's BusyBox wget could also send a URL fragment as part of that query.
Build asset URLs by extending the path while keeping the mirror query on both checksum and archive requests. The fix covers fork release metadata, the shell and PowerShell installers, the standalone npm launcher, and callers that explicitly configure an SSH archive mirror. The default Electron SSH caller supplies only its pinned version.
vp run check:changed origin/main, including affected typechecks for 34 packages and 73 passing tests (5 platform skips).Follow-up to #36, also restoring consistent URL handling where later installer work introduced parallel implementations.
GPT-6 family (Sol reviewers), Codex desktop.