Skip to content

fix(release): preserve mirror queries when downloading assets - #92

Merged
ScriptedAlchemy merged 7 commits into
mainfrom
codex/fix-release-mirror-asset-urls
Nov 9, 2026
Merged

ScriptedAlchemy merged 7 commits into
mainfrom
codex/fix-release-mirror-asset-urls

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

A release mirror configured with a query string could return 404s during an update or fresh installation. Parts of the fork appended the version and filename after the query string. Alpine's BusyBox wget could also send a URL fragment as part of that query.

Build asset URLs by extending the path while keeping the mirror query on both checksum and archive requests. The fix covers fork release metadata, the shell and PowerShell installers, the standalone npm launcher, and callers that explicitly configure an SSH archive mirror. The default Electron SSH caller supplies only its pinned version.

  • Reproduced the failure before the fix in the server metadata, shell, packed npm, and generated SSH runner tests.
  • Installed a fixture archive through a loopback HTTP mirror inside Alpine Linux ARM64. Verified both request targets, checksum, extraction, and a successful invocation. On Linux ARM64, the actual Node launcher also completed a fresh install and handled subprocess exit, signal, and timeout cases with no partial installation. Ran the installer and launcher tests on macOS ARM64.
  • Parsed the whole PowerShell script and exercised the installer URL function for 12 mirror/Windows asset combinations in PowerShell 7.6.9 on macOS. Full Windows installation remains for Windows CI.
  • Passed offline vp run check:changed origin/main, including affected typechecks for 34 packages and 73 passing tests (5 platform skips).

Follow-up to #36, also restoring consistent URL handling where later installer work introduced parallel implementations.

GPT-6 family (Sol reviewers), Codex desktop.

@changeset-bot

changeset-bot Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a7572cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy enabled auto-merge (squash) November 9, 2026 02:15
@ScriptedAlchemy
ScriptedAlchemy merged commit 5254b81 into main Nov 9, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant