Rewrite de la feature LeaderBoards - #1494
Open
ElitGaimix wants to merge 10 commits into
Open
ElitGaimix wants to merge 10 commits into
ElitGaimix wants to merge 10 commits into
Conversation
…is going to be deleted at the end of the developpement)
…n, removing runTaskTimerAsync for less Async bugs.
Patch viexerTimer bug crash
iambibi
added
⚡Optimisation
ElitGaimix
marked this pull request as ready for review
September 20, 2026 09:00
iambibi
requested changes
Sep 20, 2026
iambibi
previously approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petit résumé de la PR:
Rewrite de la feature leaderboards, optimisation et clarification du code, passage dans une architecture abstraite plutot que tout dans un seul manager. Tester completement en local sans bug.
Étape nécessaire afin que la PR soit fini (si PR en draft)
Decrivez vos changements
Creation d'une class abstraite leaderboard, et donc de chaque leaderboard héritant de cette class
Modification du manager pour n'avoir que du code de "management" des leaderboard
IMPORTANT : Modification de la config leaderboard, il faudra mettre a jour la config sur le serveur