Harden Stripe billing, slim README and homepage, bump to 5.8.0 - #415
Merged
Merged
Conversation
… and the AKS readme link
…ession anchor' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…h's version of the azure files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the Stripe billing path, slims the README and homepage, and bumps everything to 5.8.0. Nothing is tagged or published.
Billing
/api/billing/checkout/simulatereturns 404 outside simulation mode.GET /api/billing/plannow has acheckoutblock listing missing env var names, never values.Azure
deploy-azure.ymlpass the Pro and Enterprise price IDs andJOLTRIN_PUBLIC_URL. Secrets still go through Key Vault. Stripe secrets should be set as GitHub secrets, not written to Key Vault by hand, since each deploy re-applies them.Docs and site
docs/.demo/CNAMEusejoltrinhq.com.Version
scripts/update_version.sh 5.8.0. Bindings had stayed at 5.6.0 through the v5.7.0 tag.Testing
governanceandtools/httpserver, including-raceon the billing tests.go build ./...fails linkingbindings/mainon my machine because of a broken macOS SDK, unrelated to this change.Still needed in the Stripe Dashboard (not part of this PR)
Create the Pro price, create the webhook endpoint and copy its signing secret, then set the GitHub secrets and variables listed in
infra/azure/README.md.Thanks, Gerard Recinto