Skip to content

Skip Key Vault secret refs in the container app until Stripe keys are set #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gerardrecinto merged 1 commit into from
Oct 2, 2026
Merged

Skip Key Vault secret refs in the container app until Stripe keys are set #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions infra/azure/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ module containerApp 'modules/container-app.bicep' = {
userAssignedIdentityId: identity.outputs.id
userAssignedIdentityClientId: identity.outputs.clientId
keyVaultUri: keyVault.outputs.uri
stripeEnabled: !empty(stripeSecretKey) && !empty(stripeWebhookSecret)
}
}

Expand Down
12 changes: 8 additions & 4 deletions infra/azure/modules/container-app.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ param userAssignedIdentityId string
param userAssignedIdentityClientId string
param keyVaultUri string

@description('True when real Stripe secrets were supplied to the deploy. While false the app gets no Key Vault secret references and runs in simulation mode.')
param stripeEnabled bool = false

// Pinned to 1 replica: joltrin's embedded B-Tree engine has no documented
// multi-process write-safety guarantee, and this deployment optimizes for
// lowest cost over horizontal scale. CPU/memory/concurrency limits below
Expand Down Expand Up @@ -43,7 +46,7 @@ resource containerApp 'Microsoft.App/containerApps@2023-11-02-preview' = {
identity: userAssignedIdentityId
}
]
secrets: [
secrets: stripeEnabled ? [
{
name: 'stripe-secret-key'
keyVaultUrl: '${keyVaultUri}secrets/stripe-secret-key'
Expand All @@ -59,7 +62,7 @@ resource containerApp 'Microsoft.App/containerApps@2023-11-02-preview' = {
keyVaultUrl: '${keyVaultUri}secrets/stripe-publishable-key'
identity: userAssignedIdentityId
}
]
] : []
ingress: {
external: true
targetPort: 8080
Expand All @@ -84,7 +87,7 @@ resource containerApp 'Microsoft.App/containerApps@2023-11-02-preview' = {
'8080'
'-open-browser=false'
]
env: [
env: concat(stripeEnabled ? [
{
name: 'STRIPE_SECRET_KEY'
secretRef: 'stripe-secret-key'
Expand All @@ -97,11 +100,12 @@ resource containerApp 'Microsoft.App/containerApps@2023-11-02-preview' = {
name: 'STRIPE_PUBLISHABLE_KEY'
secretRef: 'stripe-publishable-key'
}
] : [], [
{
name: 'AZURE_CLIENT_ID'
value: userAssignedIdentityClientId
}
]
])
// 0.5 vCPU / 1.0 GiB: matches the requested cost-containment
// sizing. Combined GB-CPU pairing is one of ACA's valid
// combinations (0.5 vCPU pairs with 1Gi).
Expand Down
Loading