Bump the Spring Boot checkout example past the open Trivy advisories - #418
Merged
Merged
Conversation
…ckson past the open advisories
Gemini PR ReviewReviewed commit: There are no actionable findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Trivy filesystem scan now fails every PR: 36 HIGH/CRITICAL findings, all in
bindings/java/examples/spring-boot-checkout-store/pom.xml, which pins Spring Boot 3.3.4 (Tomcat 10.1.30, Jackson 2.17.2, Spring Framework 6.1.13). The file has not changed since Sep 15, and master's scan passed on Oct 1, so newly published advisories tripped it.Changes, all in that one pom:
tomcat.versionpinned to 10.1.60. Boot 3.5.16 still manages 10.1.55, which has open CRITICAL advisories fixed in 10.1.58 and later. 10.1.58 itself is not on Maven Central, so 10.1.60 is the latest published.jackson-bom.versionpinned to 2.21.7, which fixes the Jackson advisories Boot 3.5.16 (2.21.4) still carries. Matches the Jackson version already used elsewhere in the repo.The two overrides carry a comment to drop them once the parent catches up.
Checked locally:
mvn test-compileandmvn testpass (BUILD SUCCESS). The example has no tests, so this covers compilation only.mvn dependency:treeresolves Boot 3.5.16, Tomcat 10.1.60, jackson-databind and jackson-core 2.21.7.trivy fs --severity CRITICAL,HIGH --ignore-unfixedon the example: 36 findings before, 0 after.Not checked: running the app end to end. It needs the native sop4j library built locally, which I did not set up. No CI job builds this example.
Thanks, Gerard Recinto