wire the stripe pro price id and publishable key into the azure deploy - #419
Merged
Merged
Conversation
Gemini PR ReviewReviewed commit: No actionable findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container app now gets STRIPE_PRO_PRICE_ID as a plain env var when it is set. The deploy workflow passes the price ID and publishable key in from repo variables (STRIPE_PRO_PRICE_ID, STRIPE_PUBLISHABLE_KEY), so neither value lives in source. The secret key and webhook secret still go through Key Vault as before, and the app stays in simulation mode until both are set.
Still open after this merges: the webhook endpoint and the STRIPE_SECRET_KEY / STRIPE_WEBHOOK_SECRET repo secrets, and the Container Apps auth-secret deploy failure.
Thanks, Gerard Recinto