add a payment link switch for the pro request flow, empty until a live link exists - #421
Open
gerardrecinto wants to merge 1 commit into
Open
gerardrecinto wants to merge 1 commit into
gerardrecinto wants to merge 1 commit into
Conversation
Gemini PR ReviewReviewed commit:
This result blocks merge. Push a fix and comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Request Pro form now redirects to a Stripe Payment Link with the email prefilled when window.JOLTRIN_PRO_PAYMENT_LINK is set. It ships empty, so nothing changes for visitors and the email fallback stays. A test-mode link must not go there: a test-mode page cannot take a real card. When a live-mode Pro price and link exist, setting that one value in demo/index.html turns it on.
Pro is fulfilled by hand after payment, and docs/MONETIZATION_AND_TIERS.md now says so. The hosted billing code still only changes the hosted server's own tier, and nothing issues a license key to a self-hosted install, so the hosted app is not used to sell Pro.
Added an e2e test for the payment link path with the link stubbed. The existing email fallback test and the rest of the homepage spec pass on chromium.
Thanks, Gerard Recinto