Repository navigation
Fix mutex poisoning - #77
Merged
Merged
Conversation
jeffcharles
requested review from
adampetro and
pauloroberto-pozzato
and removed request for
a team
October 30, 2026 20:56
jeffcharles
force-pushed
the
jc.fix-mutex-poisoning
branch
from
October 30, 2026 21:22
2f11719 to
600a38b
Compare
jeffcharles
force-pushed
the
jc.fix-mutex-poisoning
branch
from
November 2, 2026 15:50
7048a6d to
c0c7ac4
Compare
saga-dasgupta
approved these changes
Nov 2, 2026
|
|
||
| let fn_return = f(self.store); | ||
| store_setup_started = true; | ||
| setup_store(self.store, self.weight_unit); |
There was a problem hiding this comment.
Should these 2 lines be swapped in order in case setup store fails?
Contributor
Author
There was a problem hiding this comment.
The store setup potentially failing is why store_setup_started is set first. We want to cleanup our changes to how epoch deadlines are handled if we may have changed how they're handled. I think the idea is to avoid changing the store if we haven't run any setup on it.
That said, with fresh eyes I think there's a better way to handle this.
Contributor
Author
There was a problem hiding this comment.
f9c9b86 moves cleaning up the epoch handling into the Some(ticker) case so we don't need the variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This got flagged as an unrelated issue by a code review agent when I was trying to change something else.