Repository navigation
ci: point grcov at target/debug/ for the Rust 1.100 build-dir layout - #773
Merged
Merged
Conversation
Rust 1.100 places test binaries under target/debug/build/<pkg>/<hash>/out/ instead of target/debug/deps/, so grcov panicked with "Failed to open directory target/debug/deps/" and the Test job failed on every PR. grcov walks --binary-path recursively, so target/debug/ works with both the old and the new layout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AuStkboncZthMhFiUkCzDe
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
==========================================
+ Coverage 76.84% 76.96% +0.11%
==========================================
Files 31 31
Lines 2613 2674 +61
==========================================
+ Hits 2008 2058 +50
- Misses 605 616 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ben in a daily maintenance routine.
Before: Rust 1.100 (now
stable) places test binaries undertarget/debug/build/<pkg>/<hash>/out/instead oftarget/debug/deps/. Thegrcovstep passes--binary-path target/debug/deps/, so it panics withFailed to open directory "target/debug/deps/"after all tests pass. The Test job therefore fails on every PR, which is blocking dependabot #772.After:
grcovgets--binary-path target/debug/. It searches that directory recursively, so it finds the test binaries in both the old and the new layout.How: I reproduced the failure locally with Rust 1.100.0 and grcov 0.10.8. Then I checked that
--binary-path target/debug/produces the same lcov coverage on both 1.100.0 and 1.97.0. This is the same one-argument change as SierraSoftworks/automate#447.Generated by Claude Code