Repository navigation
Draftable.Draftable: fix installer URLs for -build versions - #147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 26.8 the Draftable Velopack feed reports versions like
26.9.1-build.1. The EXE is published with that suffix, but the MSI isn't (DraftableDesktopSystem-26.9.1.msi), so the task has been stuck at 26.6.200. This change strips the suffix for the package version and the MSI URL, and keeps it for the EXE URL.I work at Draftable, the publisher. The
-build.Nsuffix is intentional on our side (Velopack version ordering), so the MSI naming will stay as it is.The 26.9.1 manifest (adds the MSI ADDLOCAL switch, which later versions should carry forward) is in microsoft/winget-pkgs#449353.