Skip to content

Test numeric comparison evaluator edge cases - #401

Merged
refeed merged 1 commit into
StackGuardian:mainfrom
sricharanreddycheruku:test/numeric-comparison-edge-cases
Oct 14, 2026
Merged

refeed merged 1 commit into
StackGuardian:mainfrom
sricharanreddycheruku:test/numeric-comparison-edge-cases

Conversation

@sricharanreddycheruku

Copy link
Copy Markdown
Contributor

Pull Request Template

Description

  • What changes are being made?

    • Add numeric-comparison edge cases for equality, floats, None and string/number inputs. Evaluator code is unchanged.
  • Why are these changes necessary?

    • The integer pass/fail examples do not distinguish strict from inclusive comparisons at equality or exercise the exception-result path. The new assertions check both the verdict and message.
  • Which issues or tickets does this PR close or relate to?

Type of Change

Checklist

  • Code has been linted.
  • Documentation has been updated (if needed). Not applicable to this tests-only change.
  • Tests have been added or updated (if needed).
  • Any breaking changes have been communicated to the team. Not applicable; behavior is unchanged.

Screenshots or Recordings (if applicable)

Not applicable.

Additional Information

Local validation on Ubuntu with Python 3.12.3, pytest 7.4.0 and Black 25.1.0:

Four evaluator test files: 40 passed in 4.84s
black --check --line-length 120 .: 125 files unchanged
CI=true GITHUB_RUN_ID=local-validation pytest tests/ -ra:
940 passed, 10 skipped in 72.14s

The last command is a local run using the repository's existing CI skip conditions. Its ten skipped tests require Terraform plans; they were not executed. No GitHub Actions run is claimed. Validation used a Linux path without spaces; the unrestricted Windows-mounted run had ten missing-Terraform failures and two unrelated UI path failures.

All 32 new evaluator cases passed. None exposed an incorrect verdict requiring an evaluator change. Other Python versions were not tested locally.

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@refeed refeed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @sricharanreddycheruku !

@refeed
refeed merged commit c9920aa into StackGuardian:main Oct 14, 2026
9 checks passed
@refeed

refeed commented Oct 21, 2026

Copy link
Copy Markdown
Member

Thank you so much for this contribution @sricharanreddycheruku!💙 We truly value the time and care you put into improving Tirith, and it means a lot to see the community help shape it. If you’re sharing your work on LinkedIn, don’t forget to tag StackGuardian so we can cheer you on! Keep them coming. We’re excited to see what you build next 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(evaluators): edge cases for the numeric comparison evaluators

2 participants