Skip to content

test(evaluators): cover IsEmpty and IsNotEmpty on 0, False and whitespace #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refeed merged 1 commit into from
Oct 21, 2026
Merged

test(evaluators): cover IsEmpty and IsNotEmpty on 0, False and whitespace #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/core/evaluators/test_is_empty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from tirith.utils import json_format_value

checks_passing = ("", None, [], dict())
checks_failing = ("stackguardian", 1, [None], dict(a=1))
checks_failing = ("stackguardian", 1, [None], dict(a=1), 0, False, " ", {"a": None})

evaluator = IsEmpty()

Expand All @@ -15,7 +15,7 @@ def test_evaluate_passing(evaluator_input):
assert result == {"message": f"{json_format_value(evaluator_input)} is empty", "passed": True}


@mark.passing
@mark.failing
@mark.parametrize("evaluator_input", checks_failing)
def test_evaluate_failing(evaluator_input):
result = evaluator.evaluate(evaluator_input)
Expand Down
20 changes: 11 additions & 9 deletions tests/core/evaluators/test_is_not_empty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,23 @@
from pytest import mark
from tirith.utils import json_format_value

evaluator_input1 = "abc"
evaluator_input2 = ""
checks_passing = ("abc", " ", {"a": None})
checks_failing = ("", 0, False)

evaluator = IsNotEmpty()


# pytest -v -m passing
@mark.passing
def test_evaluate_passing():
result = evaluator.evaluate(evaluator_input1)
assert result == {"passed": True, "message": f"{json_format_value(evaluator_input1)} is not empty"}
@mark.parametrize("evaluator_input", checks_passing)
def test_evaluate_passing(evaluator_input):
result = evaluator.evaluate(evaluator_input)
assert result == {"passed": True, "message": f"{json_format_value(evaluator_input)} is not empty"}


# pytest -v -m passing
# pytest -v -m failing
@mark.failing
def test_evaluate_passing():
result = evaluator.evaluate(evaluator_input2)
assert result == {"passed": False, "message": f"{json_format_value(evaluator_input2)} is empty"}
@mark.parametrize("evaluator_input", checks_failing)
def test_evaluate_failing(evaluator_input):
result = evaluator.evaluate(evaluator_input)
assert result == {"passed": False, "message": f"{json_format_value(evaluator_input)} is empty"}
Loading