Skip to content

chore: remove stale TODOs and commented-out code - #412

Open
Ankit-cs wants to merge 1 commit into
StackGuardian:mainfrom
Ankit-cs:chore/remove-stale-todos
Open

Ankit-cs wants to merge 1 commit into
StackGuardian:mainfrom
Ankit-cs:chore/remove-stale-todos

Conversation

@Ankit-cs

Copy link
Copy Markdown
Contributor

Related to #408

Pull Request Template

Description

  • What changes are being made?

    • Removed the stale, commented-out --input-type check under # TODO: move to core in src/tirith/cli.py.
    • Removed the redundant # TODO: LOG comment directly above logger.exception(e) in src/tirith/utils.py.
    • Confined changes exclusively to those two locations, leaving all other active # TODO comments across the codebase intact.
  • Why are these changes necessary?

    • Removes dead, commented-out code and redundant TODOs to keep the codebase clean and maintainable.
  • Which issues or tickets does this PR close or relate to?

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Other (please specify): Chore / Code Cleanup

Checklist

  • Code has been linted.
  • Documentation has been updated (if needed).
  • Tests have been added or updated (if needed).
  • Any breaking changes have been communicated to the team.

Screenshots or Recordings (if applicable)

N/A (Comment removal only)

Additional Information

  • The diff removes only comments and dead commented-out code (8 deletions total).
  • Statically verified AST syntax validity (0 syntax errors).
  • Verified test suites against modified modules.

@Ankit-cs
Ankit-cs force-pushed the chore/remove-stale-todos branch from a12c594 to b31005d Compare October 15, 2026 14:46
@Ankit-cs

Copy link
Copy Markdown
Contributor Author

looking for feedback @refeed

@Ankit-cs

Copy link
Copy Markdown
Contributor Author

Please look my pr for the above issue @refeed , @Akshat0694 , @arunim2405

@refeed

refeed commented Oct 21, 2026

Copy link
Copy Markdown
Member

Hi @Ankit-cs , thank you for the PR! sorry, but per our rule in CONTRIBUTING.md, someone has to ask for assignee first before working on it... because there's another contributor already commented on the issue, I'll give him the chance to work on that first. thank you for your understanding

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants