Repository navigation
Conversation
Ankit-cs
requested review from
Akshat0694,
arunim2405 and
refeed
as code owners
October 15, 2026 16:39
Author
|
looking for feedback @refeed |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #296
Pull Request Template
Description
What changes are being made?
_replace_vars_in_dictand added_replace_vars_in_listinsrc/tirith/core/policy_parameterization.pyto recursively substitute variables across nested dictionaries and lists.tests/core/test_policy_parameterization.pycovering nested dict and list variable substitution as well as reporting of missing variables in nested structures.Why are these changes necessary?
_replace_vars_in_dictonly walked top-level keys and skipped non-string values. Nested placeholders like{{var.x}}insidecondition.valuewere never substituted and reached evaluators as literal strings while leavingnot_found_varsempty.Which issues or tickets does this PR close or relate to?
{{var.x}}silently produces wrong verdicts #296{{var.x}}silently produces wrong verdicts #296Type of Change
Checklist