Repository navigation
fix: remove the merge_pull_request LLM tool; strip pr_url tracking suffix (0.10.1) - #92
Merged
Merged
Conversation
…ffix (0.10.1) The goal loop offered merge_pull_request to a model reading untrusted GitHub text; only prompt text said not to merge. Remove the tool and mergePullRequest(). Show pr_url without /closed or /merged in the dashboard, digest, briefing, reflection and decision docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
merge_pull_requestwas inGITHUB_TOOLS, so every tool-using dispatch offered it, including the scheduled goal loop. Goals read issues, PR bodies and comments that anyone can write, and only prompt text told the model not to merge. An injected "merge PR #N" could merge with no person involved. Without branch protection, a person merging is the control.Changes
merge_pull_requesttool, its handler, andmergePullRequest()fromgithub.ts. Nothing in core can merge a PR now. A test checks no GitHub tool name contains "merge" and that amerge_pull_requestcall isn't handled.lib/pr-url.tsprLink()strips the/closed//mergedtracking suffix the PR heartbeats append tocc_tasks.pr_url. Applied to the dashboard PR link, the daily digest email, the re-entry briefing, the reflection email and decision-doc timelines, which linked 404 URLs.Tests
tsc --noEmitclean. Full suite: 14 failures, the same known Windows-only graph/recall failures as main; everything else passes.The daemon (aegis#822) bumps to
^0.10.1once this is published, so 2.47.0 ships with no merge path in either repo. aegis-oss#91 (0.11.0) rebases on this.🤖 Generated with Claude Code