Repository navigation
AssignReviewers: request each review team member individually - #53
Merged
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 15, 2026
willson556
marked this pull request as ready for review
October 15, 2026 21:40
staflsystemsci
Bot
requested review from
a team,
fcheein,
gretl-silva-stafl,
mament0,
mns4595,
mzhu48,
nehalkpatel and
thebhef
and removed request for
a team
October 15, 2026 21:40
nehalkpatel
approved these changes
Oct 15, 2026
fcheein
approved these changes
Oct 16, 2026
Merge activity
|
On StaflSystems/StaflLib#2378, nobody from `embeddedreviewers` was requested except nehalkpatel, the assignee. mns4595 had left a comment review while the PR was a draft. **Cause:** AssignReviewers requested the `embeddedreviewers` team, unless anyone on the team had already been requested or had reviewed. That rule kept reruns from re-requesting approvers, since the team's auto-assignment (round robin, 7 of 8 members) turns a team request into individual requests for everyone, approvers included. But it was all or nothing, so one draft-time comment meant the team was never asked. **Fix:** request each team member individually, plus any assignee from outside the team. Leave out: - the author - anyone already requested (or covered by a team request someone already made) - anyone whose approval stands. A comment, or an approval later dismissed or replaced by a change request, doesn't count. Reruns and draft round-trips don't re-request approvers. An early comment no longer blocks everyone else. The team itself is never requested, so its auto-assignment settings don't affect these PRs. It still applies when someone requests the team by hand. The README, the `review-team` input description and the header comment now describe the new behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
graphite-app
Bot
force-pushed
the
setup-ccache
branch
from
October 16, 2026 17:32
822baff to
19bccac
Compare
graphite-app
Bot
force-pushed
the
assign-reviewers-individual-requests
branch
from
October 16, 2026 17:32
cb36340 to
8677e41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On StaflSystems/StaflLib#2378, nobody from
embeddedreviewerswas requested except nehalkpatel, the assignee. mns4595 had left a comment review while the PR was a draft.Cause: AssignReviewers requested the
embeddedreviewersteam, unless anyone on the team had already been requested or had reviewed. That rule kept reruns from re-requesting approvers, since the team's auto-assignment (round robin, 7 of 8 members) turns a team request into individual requests for everyone, approvers included. But it was all or nothing, so one draft-time comment meant the team was never asked.Fix: request each team member individually, plus any assignee from outside the team. Leave out:
Reruns and draft round-trips don't re-request approvers. An early comment no longer blocks everyone else. The team itself is never requested, so its auto-assignment settings don't affect these PRs. It still applies when someone requests the team by hand.
The README, the
review-teaminput description and the header comment now describe the new behavior.🤖 Generated with Claude Code