Repository navigation
Document plain text response of the thread dump endpoint - #453
Open
officialasishkumar wants to merge 1 commit into
Open
officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
The thread dump endpoint now also returns plain text when the request includes "Accept: text/plain", which Spring Boot Admin sends when downloading a thread dump from its Threads view (SteeltoeOSS/Steeltoe#1746). Replace the statement that the response is always JSON and add a sample of the plain text output, based on the existing JSON sample.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to SteeltoeOSS/Steeltoe#1746.
The thread dump endpoint now also returns plain text when the request includes
Accept: text/plain. Spring Boot Admin sends this header when you download a thread dump from its Threads view. This PR replaces "The response is always returned as JSON" with "By default, the response is returned as JSON". It also adds a plain text sample that matches the thread in the existing JSON sample.