Repository navigation
Parallelize invoice query scan and lazy-load avatar images - #965
Merged
Kingsman-99 merged 2 commits intoOct 20, 2026
Merged
Conversation
…l N+1-style RPC calls fetchInvoicesForAddress scanned candidate invoice ids one at a time with a sequential await in a for-loop, so each id's RPC/cache lookup paid the full round-trip latency of the previous one. Batch the scan with Promise.all so lookups within a batch run concurrently.
…and PresenceBar These <img> tags render in lists/bars without loading hints, so off-screen avatars (marketplace grid, presence bar) are fetched eagerly. Add loading=lazy and decoding=async so the browser defers them.
|
@deeejaymu-afk is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@deeejaymu-afk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchInvoicesForAddressscanned candidate invoice ids one-by-one with a sequentialawaitper id, so lookup latency scaled with the number of ids scanned. Switched to batchedPromise.allscanning (batches of 10) so lookups within a batch run concurrently.loading="lazy" decoding="async"to the avatar<img>tags inCreatorMarketplace(marketplace grid, potentially many off-screen items) andPresenceBar.useInfiniteInvoices(SWR Infinite, cursor pagination) wired intoDashboardClientwith an intersection-observeronVisible={loadMore}sentinel. No change needed; see issue comment.@ducanh2912/next-pwaservice worker (public/sw.js) configured innext.config.js. No change needed; see issue comment.Closes #915
Closes #914
Closes #913
Closes #912
Test plan
horizonServer.tsbatching logic (no build/test run performed per task constraints)