Repository navigation
Testing infra: factories, snapshot, a11y coverage, web vitals - #968
Merged
Kingsman-99 merged 4 commits intoOct 20, 2026
Merged
Conversation
Ad-hoc mockInvoice objects were duplicated with drifting shapes across test files. Add src/test/factories.ts with createMockInvoice() and migrate stores.test.ts to use it as a concrete example.
Vitest supports toMatchSnapshot but no snapshot tests existed. Add a concrete snapshot test for StatusBadge, a small stable presentational component, covering two prop variants.
Automated WCAG 2.1 AA checks (@axe-core/playwright) already exist for Home/Dashboard/New Invoice but not for every key page. Add Settings to the audited page list.
…ce monitoring Sentry tracing was configured (tracesSampleRate) but Core Web Vitals (CLS, LCP, INP, TTFB, FCP) were never captured. Add a WebVitalsReporter using next/web-vitals that forwards each metric to Sentry as a measurement, giving real-user performance benchmarking.
|
@chriz-cloud is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/test/factories.tswithcreateMockInvoice()to replace drifting ad-hoc mock invoices; migratedstores.test.tsas an example.StatusBadge(stable presentational component) — no snapshot tests existed previously.@axe-core/playwrighta11y gate (e2e/a11y.spec.ts) to also audit the/settingspage.WebVitalsReporter(usingnext/web-vitals) that forwards Core Web Vitals to Sentry as measurements, closing a real gap since Sentry tracing existed but Web Vitals were never captured.Test plan
npm run test— new factory usage and snapshot test pass (snapshot auto-generates on first run)npm run test:e2e -- --grep @a11y— Settings page passes the axe gateCloses #907
Closes #906
Closes #905
Closes #904