Repository navigation
Invoice branding font option, collab review, Cmd+Enter submit shortcut - #969
Merged
Kingsman-99 merged 2 commits intoOct 20, 2026
Merged
Conversation
Branding already supported logo upload, accent color, and tagline with persistence and PDF export, but font selection — an explicit acceptance requirement — was missing. Adds a fontFamily field to brand settings (Helvetica/Times-Roman/Courier, react-pdf's built-in fonts), a selector in the branding form with live preview, and wiring into both PDF export paths (invoice export and receipt).
…n wizard The ShortcutRegistry already covers navigation chords and the help overlay, but the invoice creation flow — the primary task in the app — had no keyboard shortcut to submit/advance. Registers Cmd/Ctrl+Enter via the existing useRegisterShortcuts pattern, reusing handleSubmit's existing step-advance-vs-create logic through form.requestSubmit().
|
@lonerthefirst3-sudo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@lonerthefirst3-sudo is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fontFamilybrand setting (Helvetica/Times-Roman/Courier — react-pdf's built-in fonts, no embedding needed), a selector in the branding form with live preview, and wiring into both PDF export paths.useInvoiceCollaboration,CoEditorPanel,CollaborationCursors,useInvoicePresence/PresenceBar,CommentThread,ActivityFeed), all wired into the invoice detail page. Skipped with an explanatory issue comment rather than bolting on a cosmetic, non-functional "lock" — true conflict resolution/locking is a backend-protocol change too large for this PR.useRegisterShortcutspattern.Closes #899
Closes #898
Closes #897
Test plan