Skip to content

Add co-signer approval system #914

Closed

Description

@Kingsman-99

Overview

Implement multi-signature approval workflow with signature tracking.

Requirements

  • Design approval structure
  • Implement signature verification
  • Add status tracking
  • Create approval UI hooks

Acceptance Criteria

  • Approval struct complete
  • Signatures verified correctly
  • Status transitions work
  • Concurrent approvals safe
  • Full test coverage

Definition of Done

All CI checks must pass before the PR is reviewed.

Activity

  1. added
    complexity: highComplex feature requiring deep knowledge - 200 pts
    featureNew contract feature or operation
    on Oct 16, 2026
  2. shobhamerabacha-star commented on Oct 17, 2026

    @shobhamerabacha-star

    Greetings,

    I looked into the details for "Add co-signer approval system" and would like to contribute the fix.

    Technical Implementation Outline:

    1. Review contract state storage keys, TTL policies, and auth guards (Address::require_auth).
    2. Implement safe state transition logic with checked arithmetic preventing under/overflow.
    3. Write comprehensive Soroban unit tests covering standard flows, unauthorized callers, and reverts.
    4. Verify contract execution footprint passes Soroban CPU/memory budget limits.

    Please assign this issue to me. I will submit a clean, well-tested, and production-ready PR promptly!

  3. Outlaw1299 commented on Oct 17, 2026

    @Outlaw1299

    @Outlaw1299 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I can fix this kindly assign

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Outlaw1299 to this issue.

  4. OmniZlatoon commented on Oct 17, 2026

    @OmniZlatoon

    @OmniZlatoon has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I CAN DELIVER MAINTAINER! PLEASE ASSIGN AND SEE IT WORK. ETA = 2 HOUR

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @OmniZlatoon to this issue.

  5. OZILSOLAR commented on Oct 17, 2026

    @OZILSOLAR
    Contributor

    @OZILSOLAR has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi team!!!!
    I came across this issue and would love to work on it. I have experience with similar tasks and I'm confident I can investigate, implement a clean solution, and thoroughly test it before submitting a PR. If the issue is still open, I would appreciate it if you could assign it to me. Thank you!!!!!!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @OZILSOLAR to this issue.

  6. drips-wave commented on Oct 17, 2026

    @drips-wave

    Congratulations, @OZILSOLAR! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @OZILSOLAR: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  7. grantfox-oss commented on Oct 19, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @OZILSOLAR's PR #983 was approved and merged by @Kingsman-99.

    🏆 @OZILSOLAR: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,188 total points). Track your full progress on GrantFox.

    👏 Great work, @OZILSOLAR! Keep contributing to Stellar-split.

  8. drips-wave commented on Oct 19, 2026

    @drips-wave

    This issue has been completed by @OZILSOLAR as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @OZILSOLAR: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programcomplexity: highComplex feature requiring deep knowledge - 200 ptsfeatureNew contract feature or operation

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions